-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to define vendor for the Daemon JVM criteria #28931
Open
vmadalin
wants to merge
1
commit into
gradle:release
Choose a base branch
from
vmadalin:daemon-toolchain-support-vendor
base: release
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmadalin
force-pushed
the
daemon-toolchain-support-vendor
branch
from
April 23, 2024 14:10
dfe38c3
to
6b25458
Compare
vmadalin
force-pushed
the
daemon-toolchain-support-vendor
branch
2 times, most recently
from
May 1, 2024 11:39
aadea69
to
2dabac7
Compare
vmadalin
force-pushed
the
daemon-toolchain-support-vendor
branch
from
May 1, 2024 12:27
2dabac7
to
d6d7fa6
Compare
There are new TODOs present in this change. Should any be removed? |
Change SummaryThis PR is 75.59% new code.
|
9 tasks
Signed-off-by: Madalin Valceleanu <vmadalin@google.com>
vmadalin
force-pushed
the
daemon-toolchain-support-vendor
branch
from
May 18, 2024 18:14
d6d7fa6
to
e39848c
Compare
Change SummaryThis PR is 75.25% new code.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After #28731 PR was merged the initial vendor support was removed. This PR adds the support back by following the agreed public spec document but also the recent #28934 linked to the Daemon toolchain support.
Those are changes to add support for vendor on Daemon toolchain criteria:
JvmVendor
onDaemonContext
using systemProperties to obtain its value from running daemon processJvmVendorSpec
property onUpdateDaemonJvm
task by making the class serializableUpdateDaemonJvm
task so it can still update thedaemon-jvm
properties file## Demo
Daemon.toolchain.using.vendor.mov
Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective.<subproject>/src/test
) to verify logic../gradlew sanityCheck
../gradlew <changed-subproject>:quickTest
.